Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-8457

Remove JSON Schema Resources from 1.8

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: DC/OS 1.13.0
    • Component/s: API
    • Labels:
      None

      Description

      The JSON schemas resource is hard removed in 1.8.0.

      marathon/src/main/scala/mesosphere/marathon/DeprecatedFeatures.scala

        19 |   val jsonSchemasResource = DeprecatedFeature(
        20 |     "json_schemas_resource",
        21 |     description = "Enables the /v2/schemas route. JSON Schema has been deprecated in favor of RAML and many of the definitions are not up-to-date with the current API",
        22 |     softRemoveVersion = SemVer(1, 7, 0),
        23 |     hardRemoveVersion = SemVer(1, 8, 0))
        24 | 
      

      Acceptance criteria

      The deprecated feature flag is not removed

      The following files are deleted:

      • ./src/main/scala/mesosphere/marathon/api/v2/SchemaResource.scala
      • ./docs/docs/rest-api/public/api/v2/schema/AppDefinition.json
      • ./docs/docs/rest-api/public/api/v2/schema/Group.json

      This is deleted (and all dependent test cases):

      src/test/scala/mesosphere/marathon/test/MarathonTestHelper.scala

       345 |   lazy val appSchema = {
       346 |     val appJson = "/public/api/v2/schema/AppDefinition.json"
       347 |     val appDefinition = JsonLoader.fromResource(appJson)
       348 |     val factory = JsonSchemaFactory.byDefault()
       349 |     factory.getJsonSchema(appDefinition)
       350 |   }
       351 | 
      

      The JSON schema validator dependency is removed:

      project/Dependencies.scala

       122 |     val JsonSchemaValidator = "2.2.6"
      

      And, things compile / work again, etc.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nikitamelkozerov Nikita Melkozerov (Inactive)
                Reporter:
                tharper Tim Harper
                Team:
                Orchestration Team
                Watchers:
                Mergebot, Tim Harper
              • Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: