Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-8319

Remove misleading and confusing implicit conversion with mesos tty

    Details

      Description

      In mesos implicits, we have this gem:

      /Users/tim/src/m8e/marathon/src/main/scala/mesosphere/mesos/protos/Implicits.scala
      
        78 |   implicit def ttyToProto(tty: Boolean): Protos.TTYInfo = Protos.TTYInfo.newBuilder().build()
        79 | 
        80 |   implicit def protoToTTY(proto: Protos.TTYInfo): Boolean = true // if anything as tty is configured in the proto, we return true
        81 | 
      

      There's simply no possible good reason we should implicitly throw away a boolean value. This should be explicit, and well documented.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                tharper Tim Harper
                Team:
                Orchestration Team
                Watchers:
                Matthias Eichstedt, Tim Harper
              • Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: