Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-7769

Improve pod health check validation messages

    Details

    • Type: Task
    • Status: Accepted
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: API

      Description

      Gastón Kleiman and I found this whilst debugging https://jira.mesosphere.com/browse/DCOS_OSS-1639

      The effect: attempting to start a pod from the DC/OS UI with a healthcheck interval below 20 (the default timeout) leads to an error message:

      There is an error with your configuration
      - containers.0.healthCheck: got 20, expected less than 5

      This is not an obvious error, since the user is now on a different screen from the health check. It's also an unnecessary constraint. There's no need to constrain the interval to be less than the timeout, since they run in sequence. 

      This is the pod definition which we were attempting to deploy.

      {
        "id": "/philip/failure",
        "containers": [
          {
            "name": "container-1",
            "resources": {
              "cpus": 0.1,
              "mem": 128
            },
            "healthCheck": {
              "exec": {
                "command": {
                  "shell": "true"
                }
              },
              "intervalSeconds": 5
            },
            "exec": {
              "command": {
                "shell": "sleep 12345"
              }
            }
          }
        ],
        "scaling": {
          "instances": 1,
          "kind": "fixed"
        },
        "networks": [
          {
            "mode": "host"
          }
        ],
        "volumes": [],
        "fetch": [],
        "scheduling": {
          "placement": {
            "constraints": []
          }
        }
      }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                philip Philip Norman
                Team:
                Orchestration Team
                Watchers:
                Karsten Jeschkies, Marco Monaco, Philip Norman
              • Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: