Details

      Description

      See the snippet below.

      curl -s :2015/metrics | jq '. | keys'
      [
        "`min-max-counter`",
        "counter",
        "counters",
        "end",
        "gauge",
        "gauges",
        "histogram",
        "histograms",
        "min-max-counter",
        "start",
        "system-metric"
      ]
      
      $ curl -s :2015/metrics | jq '.counters | keys'
      [
        "GarbageCollector.totalGcs",
        "org.eclipse.jetty.ServletContextHandler.1xx-responses",
        "org.eclipse.jetty.ServletContextHandler.2xx-responses",
        "org.eclipse.jetty.ServletContextHandler.3xx-responses",
        "org.eclipse.jetty.ServletContextHandler.4xx-responses",
        "org.eclipse.jetty.ServletContextHandler.5xx-responses",
        "org.eclipse.jetty.ServletContextHandler.api-errors",
        "service.mesosphere.marathon.core.storage.store.impl.cache.LazyVersionCachingPersistentStore.get"
      ]
      
      $ curl -s :2015/metrics | jq '.counter | keys'
      [
        "GarbageCollector.totalGcs",
        "org.eclipse.jetty.ServletContextHandler.1xx-responses",
        "org.eclipse.jetty.ServletContextHandler.2xx-responses",
        "org.eclipse.jetty.ServletContextHandler.3xx-responses",
        "org.eclipse.jetty.ServletContextHandler.4xx-responses",
        "org.eclipse.jetty.ServletContextHandler.5xx-responses",
        "org.eclipse.jetty.ServletContextHandler.api-errors",
        "service.mesosphere.marathon.core.storage.store.impl.cache.LazyVersionCachingPersistentStore.get"
      ]
      
      $ curl -s :2015/metrics | jq '.counters["GarbageCollector.totalGcs"]'
      {
        "count": 2,
        "tags": {},
        "unit": {
          "name": "unknown",
          "label": "unknown"
        }
      }
      
      $ curl -s :2015/metrics | jq '.counter["GarbageCollector.totalGcs"]'
      {
        "count": 2,
        "tags": {},
        "unit": {
          "name": "unknown",
          "label": "unknown"
        }
      }
      

      I think we should remove the singular versions in order to stay in line with the way 1.4.x output the metrics:

      [
        "counters",
        "gauges",
        "histograms",
        "meters",
        "timers",
        "version"
      ]
      

      We should also get rid of the back-tick enclosed mix-max-counter key.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                marco.monaco Marco Monaco
                Reporter:
                tharper Tim Harper
                Team:
                Orchestration Team
                Watchers:
                Tim Harper
              • Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: