Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-5618

WIP on resident task offer matching and reserve/launch operations

    Details

    • Type: Task
    • Status: Resolved
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Goal: resolve MGI-3042

      Changes:

      • moved TaskOps into a dedicated object TaskOp
      • creation of TaskOps is delegated from AppTaskLauncherActor to taskOpLogic
      • adjusted AppTaskLauncherActor to handle TaskOps Launch and ReserveAndCreate
      • introduced an OfferOperationFactory – reserve and create both need the framework role and principal and are thus easier to handle as wired class objects rather than singleton objects
      • adjusted DefaultTaskOpLigic to infer TaskOps depending on whether the app is resident or not.
      • new functions in the TaskBuilder targeting resident apps expect a ResourceMatch/VolumeMatch to be passed in (in order to decide which taskOp to generate, we need to know whether there's a volumeMatch or not – before using tha taskBuilder)

      Open points:

      • validate the responsibilities of TaskOpLogic/TaskBuilder and related classes
      • validate the counting logic inside AppTaskLauncherActor
      • write unit/integration tests for resident tasks that verify the behavior on each layer
      • role and principal are currently passed along from DefaultTaskOpLogic to TaskOpFactory to OfferOperationFactory. This is ugly but the alternative would be to wire all these via Guice.
      • ... surely some more open points

        Attachments

          Activity

            People

            • Assignee:
              matthias Matthias Veit (Inactive)
              Reporter:
              matthias.eichstedt Matthias Eichstedt
              Team:
              Orchestration Team
              Watchers:
              Marco Monaco
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: