Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-4338

GcActor should use InstanceTracker to ensure we don't delete apps that are still being used.

    Details

    • Type: Task
    • Status: Accepted
    • Priority: High
    • Resolution: Unresolved
    • Affects Version/s: Marathon 1.3.10, Marathon 1.4.1
    • Fix Version/s: None
    • Component/s: Persistence

      Description

      Marathon version: 1.3.10 
      Mesos version: 1.0.2
      

      When app scaling action is made more than zk_max_version times and then Marathon is restarted application configuration (and health checks conf) are lost.

      There is WARN in log:
      > WARN Cannot find health check configuration for [appname] and version [date], using most recent one. (mesosphere.marathon.core.health.impl.MarathonHealthCheckManager:ForkJoinPool-2-worker-151)

      but as in: https://github.com/mesosphere/marathon/blob/17d27b6acf3e202f5113a401ab39e176135efb46/src/main/scala/mesosphere/marathon/core/health/impl/MarathonHealthCheckManager.scala#L172 health check configuration is not copied and task is in Unknown state.

      Reproduction

      1. Create an application with health-check
      2. Scale it many times adding one instance
      3. Restart marathon
      4. The oldest instance will lost its health-check

      Shows

      WARN Cannot find health check configuration for [/application] and version [2017-03-16T12:41:08.995Z], using most recent one. (mesosphere.marathon.core.health.impl.MarathonHealthCheckManager:ForkJoinPool-2-worker-3)
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ojagodzinski Oskar Jagodziński
                Team:
                Marathon Team
                Watchers:
                Chmielewski, janisz, Jason Gilanfarr (Inactive), Karsten Jeschkies
              • Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: