Uploaded image for project: 'Marathon'
  1. Marathon
  2. MARATHON-3284

Passing routes by the properties to Marathon

    Details

    • Type: Task
    • Status: Resolved
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None

      Description

      As suggested by [~ssorallen] routes should not be handled in the componentDidUpdate in Marathon.jsx, instead passed by the properties to Marathon.jsx. So Marathon doesn't have knowledge of the Router.

      Backbone.Router.extend({
        routes: {
          'home': 'home'
        },
        home: function() {
          React.render(
            <Marathon page='home'>,
            ...
          );
        }
      });
      Backbone.History.start();
      

      https://github.com/mesosphere/marathon/issues/325#issuecomment-71501106

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              GitHub_aldipower Felix Gertz (Inactive)
              Team:
              Orchestration Team
              Watchers:
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: