Uploaded image for project: 'DC/OS'
  1. DC/OS
  2. DCOS_OSS-4945

Annotate all upstreams including original URI for Admin Router metrics

    Details

      Description

      We've annotated the static upstreams for th fine-grained Admin Router metrics effort, now we need to look into how to do the same thing for dynamically resolvable upstreams.

      This is tricky because we employ this hack to enable dynamically resolvable upstreams at all in the free version of Nginx:
      https://tenzer.dk/nginx-with-dynamic-upstreams/

      One can then not just collect the $upstream_addr as we do for static upstreams.

      Since all our upstreams use `proxy_pass` we can maybe unify dynamically resolvable and static upstream reporting by using `$proxy_host` and `$proxy_port` instead of `$upstream_addr`.
      http://nginx.org/en/docs/http/ngx_http_proxy_module.html#var_proxy_host

        Attachments

          Activity

            People

            • Assignee:
              timweidner Tim Weidner
              Reporter:
              timweidner Tim Weidner
              Team:
              Security Team
              Watchers:
              Adam Dangoor, Mergebot, Tim Weidner
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: