Uploaded image for project: 'DC/OS'
  1. DC/OS
  2. DCOS_OSS-4829

tox failure: test_config.test_validate_check_config

    Details

    • Story Points:
      1

      Description

      The test test_config.test_validate_check_config in the tox job is failing with this error:

      new_arguments = {'check_config': '{"cluster_checks": {}}'}, key = 'check_config'
      message = "Key 'cluster_checks' error: Missing keys: Check name must be a nonzero length string with no whitespace"
      unset = None
      
          def validate_error(new_arguments, key, message, unset=None):
      >       assert gen.validate(arguments=make_arguments(new_arguments)) == {
                  'status': 'errors',
                  'errors': {key: {'message': message}},
                  'unset': set() if unset is None else unset,
              }
      E       assert {'errors': {'...unset': set()} == {'errors': {'c...unset': set()}
      E         Common items:
      E         {'status': 'errors', 'unset': set()}
      E         Differing items:
      E         {'errors': {'check_config': {'message': "Key 'cluster_checks' error: Missing key: Check name must be a nonzero length string with no whitespace"}}} != {'errors': {'check_config': {'message': "Key 'cluster_checks' error: Missing keys: Check name must be a nonzero length string with no whitespace"}}}
      E         Full diff:
      E         {'errors': {'check_config': {'message': "Key 'cluster_checks' error: Missing "
      E         -                                         'key: Check name must be a nonzero '
      E         +                                         'keys: Check name must be a nonzero '
      E         ?                                             +
      E         'length string with no whitespace'}},
      E         'status': 'errors',
      E         'unset': set()}
      
      gen/tests/utils.py:44: AssertionError
      

      This is because the new release of the schema Python package (0.7.0, Feb 25) changes wording in an error message that is assumed by the failing test (schema PR here). schema isn't pinned, so we pulled in this new release automatically without any corresponding commits against DC/OS.

        Attachments

          Activity

            People

            • Assignee:
              branden Branden Rolston
              Reporter:
              branden Branden Rolston
              Team:
              Dev Prod Team
              Watchers:
              Anitha Muthu (Inactive), Branden Rolston, Lisa Gunn, Mergebot
            • Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: